Skip to content

Feat: Let unplaced functions of switched-off features through, find class tables by name, open tabs by command id - #225

Merged
b-re-w merged 4 commits into
developfrom
feat/rows-functions-off
Nov 14, 2026
Merged

b-re-w merged 4 commits into
developfrom
feat/rows-functions-off

Conversation

@b-re-w

@b-re-w b-re-w commented Nov 14, 2026

Copy link
Copy Markdown
Member

NFR-6, D16 steps 1 to 4 in the row generator and runtime. Code only: nothing was built or run in the worktree. Build and tests run on develop after merge.

Changes

  1. Unplaced functions of a feature that is off do not block the row (row_port.rs, row_features.rs)
    • An address no method placed now stops the row only when a part the window cannot do without holds it (the frame, the page area layout, tabs, navigation, toolbar). Where every holder belongs to a feature with a switch, or is unused in this row, the values are cleared, the feature goes off, and the address is listed in the new unplaced report field.
    • The sidebar's and the vertical tab controller's functions and tables, plus the developer font functions, joined their features. Each one was checked against its reader first: only that feature reads it, and only once its targets are recorded.
    • vertical.should_draw_tab_strip counts as unused when vertical.detour_strip is false.
    • A failed recipe for a value of a switchable feature now turns that feature off instead of stopping the row.
  2. Class tables by class name (new row_class.rs, row_resolve.rs, bin/chrome-builds.rs)
    • From a views class name: the code that uses the text and its callers, then the ClassMetaData static they load, the GetClassMetaData functions and thunks that return it, and the MetaDataProvider tables whose slot 1 holds them. Last comes the table the constructors write at offset 0 of the same object.
    • The load is decoded like the runtime's chromium/reflect.rs::load_target.
    • A name counts only when the same reading gives the prior row's table in the prior build. The class comes from the prior PDB's ??_7Class@@... symbol.
    • New methods its class name and its fingerprint. The second is a place that a class name or a table slot gives which is one of the fingerprint's places.
    • A table found by its class name is also compared slot by slot. Functions then follow by their slot in the found tables, together with their fingerprint.
  3. New tab by IDC_NEW_TAB (command_ids.rs, commands.rs, features/tabs.rs)
    • The id comes from chrome/app/chrome_command_ids.h at branches 7499 and 7871 through 8154 (34014 at every one).
    • A Rivet window now opens a tab with the command for every known build. chrome::NewTab is called directly only for a milestone without a read id.
    • The runtime has no DevTools Protocol client, and launches have no --remote-debugging-pipe. Open URL, active tab and tab at index therefore still use their functions.

Tests (not run here)

  • nfr6_unplaced_functions_of_a_feature_that_is_off_do_not_block_the_row
  • nfr6_a_frame_vtable_is_found_from_its_class_name, nfr6_a_class_whose_constructor_writes_no_first_table_gives_none, nfr6_a_class_name_counts_only_where_it_gives_the_prior_table_in_the_prior_build, nfr6_a_table_symbol_names_its_class
  • nfr6_a_class_table_is_taken_where_its_class_name_and_fingerprint_agree
  • nfr6_a_new_tab_uses_the_public_command, nfr6_the_new_tab_command_comes_from_chromium_command_ids

Still open

  • tabs.new_tab is still a required value. The new tab hook on chrome::NewTab keeps an app window's tab in that window and opens the start page, and no public command does that. Whether a build may run without it needs an owner decision.
  • Tabs and navigation have no switch here. Turning them off per build also needs an owner decision.

🤖 Generated with Claude Code

@b-re-w
b-re-w merged commit 540e5b4 into develop Nov 14, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant