Repository navigation
Feat: Let unplaced functions of switched-off features through, find class tables by name, open tabs by command id - #225
Merged
Conversation
…ts functions by slot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NFR-6, D16 steps 1 to 4 in the row generator and runtime. Code only: nothing was built or run in the worktree. Build and tests run on develop after merge.
Changes
row_port.rs,row_features.rs)unplacedreport field.vertical.should_draw_tab_stripcounts as unused whenvertical.detour_stripis false.row_class.rs,row_resolve.rs,bin/chrome-builds.rs)ClassMetaDatastatic they load, theGetClassMetaDatafunctions and thunks that return it, and theMetaDataProvidertables whose slot 1 holds them. Last comes the table the constructors write at offset 0 of the same object.chromium/reflect.rs::load_target.??_7Class@@...symbol.its class nameandits fingerprint. The second is a place that a class name or a table slot gives which is one of the fingerprint's places.IDC_NEW_TAB(command_ids.rs,commands.rs,features/tabs.rs)chrome/app/chrome_command_ids.hat branches 7499 and 7871 through 8154 (34014 at every one).chrome::NewTabis called directly only for a milestone without a read id.--remote-debugging-pipe. Open URL, active tab and tab at index therefore still use their functions.Tests (not run here)
nfr6_unplaced_functions_of_a_feature_that_is_off_do_not_block_the_rownfr6_a_frame_vtable_is_found_from_its_class_name,nfr6_a_class_whose_constructor_writes_no_first_table_gives_none,nfr6_a_class_name_counts_only_where_it_gives_the_prior_table_in_the_prior_build,nfr6_a_table_symbol_names_its_classnfr6_a_class_table_is_taken_where_its_class_name_and_fingerprint_agreenfr6_a_new_tab_uses_the_public_command,nfr6_the_new_tab_command_comes_from_chromium_command_idsStill open
tabs.new_tabis still a required value. The new tab hook onchrome::NewTabkeeps an app window's tab in that window and opens the start page, and no public command does that. Whether a build may run without it needs an owner decision.🤖 Generated with Claude Code